https://github.com/GoogleCloudPlatform/cloudsql-proxy/issues/385

exenin commented 4 years ago

https://github.com/forseti-security/helm-charts/issues/72

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

gkowalski-google commented 4 years ago

/gcbrun

gkowalski-google commented 4 years ago

Thanks @exenin for the PR and issue! I ran into this issue as well. I tried updating to GKE master version 1.15.11-gke.9 and was able to work past it (someone in that other issue mentioned not seeing it in 1.15). This is probably the best way to resolve it for 1.14. Not sure why the tests failed, I can look into that if you want to move forward. Before we can merge the PR you will need sign the CLA mentioned above.

gkowalski-google commented 4 years ago

Hi @exenin, pinging on my comment above. Just checking if you are still using 1.14 or if you have tried using 1.15. If still on 1.14 and want this change in, then I can approve and merge.

forseti-security / helm-charts