forseti-security / helm-charts

Apache License 2.0
8 stars 11 forks source link

adding kube proxy image tag #74

Closed shraykay closed 4 years ago

shraykay commented 4 years ago

while attempting to run this chart on gke 1.15 the kube-proxy container image errors out with: "error: default cluster has no server defined"

by matching the kube-proxy image tag to the one running in our gke environment (GitVersion:"v1.15.9-gke.24") I was able to get this running.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

shraykay commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gkowalski-google commented 4 years ago

/gcbrun

shraykay commented 4 years ago

@gkowalski-google thank for you looking at my PR! would you mind re-running the cloudbuild, I made a typo on my previous commit.

gkowalski-google commented 4 years ago

Thanks @shraykay for the PR! Unfortunately our test infra is not available right now, which is why the tests were failing. This change looks good to me.