forseti-security / helm-charts

Apache License 2.0
8 stars 11 forks source link

fix(forseti-security): fix Helm error #81

Closed ThibaultLengagne closed 3 years ago

ThibaultLengagne commented 3 years ago

Proposal to fix an error in the Helm chart.

For more info : https://github.com/helm/helm/issues/8311

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

ThibaultLengagne commented 3 years ago

@googlebot I signed it!

gkowalski-google commented 3 years ago

Thanks for this @ThibaultLengagne, can you clarify what versions of Helm this is fixing and what version you are using? Just want to make sure this is compatible with the existing Terraform module, which I believe most people are using 0.10.4.

ThibaultLengagne commented 3 years ago

Hi @gkowalski-google,

tony-mw commented 3 years ago

Can we get a release with this fix?

thomascrowley commented 3 years ago

Seconding @tony-mw 's comment. Any news on this getting released?

gkowalski-google commented 3 years ago

To confirm, you just need us to publish a new chart to Helm Hub, correct?

thomascrowley commented 3 years ago

Hi @gkowalski-google, apologies for the delay your response got buried in my Junk. But yes please, now this has been merged into master it would be great if this could get published.