search

forseti-security / terraform-google-forseti

A Terraform module for installing Forseti on GCP
Apache License 2.0
132 stars 126 forks source link

Specify the micro version of TF binary in all versions.tf #364

Closed kevensen closed 4 years ago

kevensen commented 5 years ago

Right now, the specified version of TF is specified as 0.12. There have been issues between micro versions.

We should consider posting the supported TF version (with micro version) in the release notes as well as release communications.

morgante commented 5 years ago

We should be able to specify the micro version in versions.tf: https://www.terraform.io/docs/configuration/terraform.html#gt--1

I'd suggest ~> 0.12.6.

kevensen commented 5 years ago

I misunderstood a conversation I had with @aaron-lane. If we can fix the micro version here, then my two cents is that we should. We also would like to be consistent with the rest of CFT. @morgante would we create a conflict if we set the micro version here and the rest of the CFT modules didn't?

morgante commented 5 years ago

Nope, that's fine.

red2k18 commented 4 years ago

Pinning a specific minor Terraform version is discouraged as this will make users lives much harder; they won't be able to update to a new Terraform version (even for other modules). No other CFT or reusable modules do this, and HashiCorp strongly discourages it.