Replace deprecated enable_logging with log_config for Firewall resources

forseti-security / terraform-google-forseti

A Terraform module for installing Forseti on GCP

Apache License 2.0

132 stars 126 forks source link

Replace deprecated enable_logging with log_config for Firewall resources #604

Closed gkowalski-google closed 4 years ago

gkowalski-google commented 4 years ago

The enable_logging input for firewall resources is deprecated in favor of log_config. Update the firewall resources to use this new input.

Sample warning:

Warning: "enable_logging": [DEPRECATED] Deprecated in favor of log_config

  on ../../../modules/client/main.tf line 152, in resource "google_compute_firewall" "forseti-client-deny-all":
 152: resource "google_compute_firewall" "forseti-client-deny-all" {

gkowalski-google commented 4 years ago

The log_config block was just recently added to google_compute_firewall resources as part of Google provider release 3.33.0. In order to replace enable_logging in this module, the minimum version would have to be set to 3.33.0; which will not be done at this time.