search

forseti-security / terraform-google-forseti

A Terraform module for installing Forseti on GCP
Apache License 2.0
132 stars 126 forks source link

Update description of variable "crm_period" #609

Closed jeremiahbailey closed 4 years ago

jeremiahbailey commented 4 years ago

Corrected 'CRN' to 'CRM' in line 301

gkowalski-google commented 4 years ago

Hi @JT-Bailey, thanks for fixing this. The lint tests failed because there are a few other places where this typo exists, and the lint tests assert that the variable descriptions are the same throughout the module. Would you mind fixing those other instances as well?

jeremiahbailey commented 4 years ago

Sure thing Gregg. I'll update the PR.

On Tue, Aug 25, 2020 at 2:23 PM Gregg Kowalski notifications@github.com wrote:

Hi @JT-Bailey https://github.com/JT-Bailey, thanks for fixing this. The lint tests failed because there are a few other places where this typo exists, and the lint tests assert that the variable descriptions are the same throughout the module. Would you mind fixing those other instances as well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/forseti-security/terraform-google-forseti/pull/609#issuecomment-680193763, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJ5K66UGEQO3HIHVBBWHCDSCP6Q3ANCNFSM4QKNALIA .

-- Jeremiah Tirado-Bailey

gkowalski-google commented 4 years ago

@JT-Bailey Instead of submitting another PR, you can just update your existing branch and push.

stale[bot] commented 4 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.