forseti-security / terraform-google-forseti

A Terraform module for installing Forseti on GCP
Apache License 2.0
132 stars 126 forks source link

Forseti on GKE uses default node pool name #612

Closed paul-r0ss closed 3 years ago

paul-r0ss commented 4 years ago

When we are trying to deploy Forseti with terraform on existing GKE cluster, we are experiencing that the module uses a default value for nodeSelctors. It leads to time out under deploy with helm. Pod cannot start and fails with: pod didn't trigger scale-up (it wouldn't fit if a new node is added): 1 node(s) didn't match node selector

Actual Behaviour terraform config

output from terraform plan

Expected Behaviour output from terraform plan

... + "nodeSelectors: ['cloud.google.com/gke-nodepool=pool-1']",

Other info We need to use helm chart 0.10.4 due to an error we get with 0.10.5 (related this issue:

module.forseti-on-gke.module.forseti.data.http.server_config_contents: Refreshing state... module.forseti-on-gke.module.forseti.helm_release.forseti-security: Creating... Error: rpc error: code = Unknown desc = render error in "forseti-security/templates/orchestrator/network-policies/default-deny-ingress-egress.yaml": template: forseti-security/templates/orchestrator/network-policies/default-deny-ingress-egress.yaml:15:6: executing "forseti-security/templates/orchestrator/network-policies/default-deny-ingress-egress.yaml" at <(.Values.networkPolicy.enabled) and (.Values.orchestrator.enabled)>: can't give argument to non-function .Values.networkPolicy.enabled on .terraform/modules/forseti-on-gke/modules/on_gke/main.tf line 221, in resource "helm_release" "forseti-security": 221: resource "helm_release" "forseti-security"

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

Pavloro commented 3 years ago

the problem is still not resolved

Pavloro commented 3 years ago

Hi, It's not possible to override default value in NodeSelectors in forseti chart.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.