Closed gaima8 closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@gaima8 This change looks fine to me. If you are looking to modify the default rules that ship with Forseti, then you should set manage_rules_enabled = false
. When set to false, the Terraform module will not overwrite any rules in GCS during deployment.
Ignoring content and md5 hash changes tells me you really want to allow the end user to change rules without the module overwriting them. So ignore content_language too.
We're using CFT to manage this deployment if that makes any difference.