forseti-security / terraform-google-forseti

A Terraform module for installing Forseti on GCP
Apache License 2.0
132 stars 126 forks source link

Cloud SQL instances can no longer be deleted without setting deletion_protection = false #619

Closed e-koma closed 1 year ago

e-koma commented 3 years ago

Cloud SQL deletion_protection option is set by default true above terraform-provider-google version 3.44, and cannot delete it. https://github.com/hashicorp/terraform-provider-google/blob/master/CHANGELOG.md#3440-october-19-2020

deletion_protection option is not set, so should parameterized it.

We usualy use terraform-provider-google version above 3.44. So the tests in the terraform-google-forseti repository are failed in our local environment, because cannot delete Cloud SQL instances.

Pavloro commented 3 years ago

I get the same issue

e-koma commented 3 years ago

Pull Reqequest has been automatically closed 😭

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

e-koma commented 3 years ago

😭 😭 😭

gkowalski-google commented 3 years ago

sorry 😢 I tried to finish this, but kept running into various Terraform issues. You can try branching from https://github.com/forseti-security/terraform-google-forseti/pull/628 and see if you can finish it. I forget what the last error was that I ran into...

e-koma commented 3 years ago

@gkowalski-google

OK, I will try it because it will be useful for everyone !! but I can't see the following test results. https://github.com/forseti-security/terraform-google-forseti/pull/628/checks?check_run_id=2586364285

Is it possible for you to grant me access to Cloud Build? or Coud you please negotiate to Administrator?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

e-koma commented 3 years ago

Issue still remain.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

e-koma commented 2 years ago

Issue still remain.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

e-koma commented 2 years ago

maybe Issue still remain.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

e-koma commented 1 year ago

:smiling_face_with_tear:

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

e-koma commented 1 year ago

🥲