Closed e-koma closed 3 years ago
/gcbrun
Thanks! This change looks good, waiting for the tests to complete.
A few of the tests failed where the VMs did not start properly, I'll need to look into that to see what happened.
@e-koma Can you edit this PR to merge the change into master? We would need to create a new minor release once the change is merged in.
@gkowalski-google
Oh, I see.
however, the master
branch already contains another method for google-cloud-sdk installation.
master
branch script seems to work fine, so this Pull Request is not necessary for master
branch.
Or, I need to understand the branch history.
modulerelease522
is the latest version, we need to merge master
to modulerelease522
branch.master
branch is the latest version, we need to modify the forseti document.
https://forsetisecurity.org/docs/latest/setup/install/index.html#create-the-service-account-and-enable-required-apis
(I understand modulerelease522
is the latest branch because the forseti docs specify to modulerelease522
. )If you know any history history, could you please let me know?
@gkowalski-google
Oh, I see. however, the
master
branch already contains another method for google-cloud-sdk installation.master
branch script seems to work fine, so this Pull Request is not necessary formaster
branch.Or, I need to understand the branch history.
- if
modulerelease522
is the latest version, we need to mergemaster
tomodulerelease522
branch.- but If
master
branch is the latest version, we need to modify the forseti document. https://forsetisecurity.org/docs/latest/setup/install/index.html#create-the-service-account-and-enable-required-apis (I understandmodulerelease522
is the latest branch because the forseti docs specify tomodulerelease522
. )If you know any history history, could you please let me know?
Sorry, you are right! I wasn't sure if this was an issue that existed on the main branch. I will try to spend some time to figure out why the tests are failing.
I updated the PR to point to a new release branch. I'm working on getting access to the test logs so I can see why these failed.
thanks 🙏
/gcbrun
/gcbrun
thank you!!
Summery
Currently, when creating the forseti in GCE with Terraform, the forseti startup-script does not work. In the forseti slack community, forseti newers regularly mention that "I can't install forseti" , and each time I've guided them to #618.
Applying this Pull Request, forseti startup-script will work. many people are having trouble, could you please merge it?
Error
yum install google-cloud-sdk
in the forseti startup-script failsCause
I guess this is because google-cloud-sdk has been deleted from the ubuntu package. but google-cloud-sdk is already installed on GCE instances by default, so we can simply remove google-cloud-sdk.
618 was auto-closed, but I think this fix is necessary, so I re-created a Pull Request.