search

forseti-security / terraform-google-forseti

A Terraform module for installing Forseti on GCP
Apache License 2.0
132 stars 127 forks source link

Update minimum version of the Google provider to 3.52 #627

Closed gkowalski-google closed 3 years ago

gkowalski-google commented 3 years ago

This is needed to support the deletion_protection argument for CloudSQL and using the last version of the Cloud NAT module which works with Terraform 0.12. The lint tests will pass, and int test will still fail on not being able to delete the test VMs. The next PR will actually get the tests all passing 👍

gkowalski-google commented 3 years ago

Hi @morgante, just thought I'd check with you to see if you have any concern raising up the minimum required version of the Google provider here. This is being done so that we can add the deletion_prevention variable to allow for the Cloud SQL instance to be deleted.

gkowalski-google commented 3 years ago

The tests all passed except for failing to delete the Cloud SQL instances.

morgante commented 3 years ago

Hi @morgante, just thought I'd check with you to see if you have any concern raising up the minimum required version of the Google provider here. This is being done so that we can add the deletion_prevention variable to allow for the Cloud SQL instance to be deleted.

No problem for me, go ahead.