forseti-security / terraform-google-forseti

A Terraform module for installing Forseti on GCP
Apache License 2.0
132 stars 127 forks source link

Fix/gcs terraform #632

Closed CpBulletSponge closed 3 years ago

CpBulletSponge commented 3 years ago

Updated terraform code to remove gcs 'bucket_policy_only' which is to be deprecated to use 'uniform_bucket_level_access'

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

CpBulletSponge commented 3 years ago

@googlebot I signed it!

gkowalski-google commented 3 years ago

I'm not opposed to this change, but it is a breaking change for existing users who are using the main branch to deploy Forseti.

gkowalski-google commented 3 years ago

An alternative is to keep the bucket_policy_only var along with the new uniform_bucket_level_access. Use a local var to decide which one to use.

stale[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.