search

forslund / combo-lock

Apache License 2.0
4 stars 1 forks source link

Handle FileNotFound after lock init #16

Closed NeonDaniel closed 1 year ago

NeonDaniel commented 1 year ago

Closes #15

forslund commented 1 year ago

Looks like a good workaround, merging

forslund commented 1 year ago

Oh, hmm...a thought occurred. Should the try-except thing be moved into the the acquire() method. so usage without with would work the same way?

Edit: Proposed implementation: https://github.com/forslund/combo-lock/commit/f1779b10cafe0dea17d7f0699a5f516e45c5ee9c

NeonDaniel commented 1 year ago

Oh, hmm...a thought occurred. Should the try-except thing be moved into the the acquire() method. so usage without with would work the same way?

Edit: Proposed implementation: f1779b1

That's probably a better implementation. Is that already merged, or is there a PR with that coming?

forslund commented 1 year ago

Did a rebase and created PR #17

JarbasAl commented 1 year ago

merged via #17