search

forslund / mopidy_skill

A Mycroft skill for controlling the mopidy media player
GNU General Public License v3.0
15 stars 14 forks source link

Missing requirements.txt #25

Closed ProjectMoon closed 4 years ago

ProjectMoon commented 4 years ago

When installing, no requirements.txt is specified. This skill depends on the fuzzywuzzy module, which has to be installed manually.

forslund commented 4 years ago

Thanks for reporting, I added it to the cps-update branch.

ProjectMoon commented 4 years ago

Here is another dependency for you to add: python-Levenshtein

If this isn't installed, fuzzywuzzy emits a warning about falling back to a very slow pure Python implementation, which takes around 8-10 seconds per request to find a match. This is, of course, far beyond the magic 5 second search timeout of mycroft-core. Installing python-Levenshtein makes the search return a match almost instantly.

Without this dependency, the skill basically doesn't work because it takes too long to find matches.

ProjectMoon commented 4 years ago

Of course, this introduces some other issues, e.g. "Play Backdrifts by Radiohead" returns some interesting results (certainly not the actual song Backdrifts).

forslund commented 4 years ago

Ow that's a long time to fuzzymatch, you have a larger library than me :) I've updated the PR to include python-Levenshtein as well

As for the second issue with play x by/with y I plan to port over some of the parsing from the spotify skill handling this kind of thing after the basic artist/track/album extractions are in and works ok.