search

forslund / spotify-skill

Mycroft Skill to control spotify using the Spotify Connect API
Apache License 2.0
71 stars 38 forks source link

Add support for playing saved songs #127

Closed TheLastProject closed 4 years ago

TheLastProject commented 4 years ago

Fixes #125.

This was painful. Spotify's API is... inconsistent. And Mycroft didn't like me returning a HUGE data payload to the Playback Control Skill.

But this works. This works great. It's fast, it picks a different 200 random songs each time you tell it to play your liked songs. It even handles it well if you literally, like me, have thousands and thousands of saved songs.

Oh yeah, please squash these commits when you merge it :)

forslund commented 4 years ago

I've tested this and seems to work great, sorry for the long delay in reviewing. Do you think you could rebase and squash some of the commits into their "logical position"? If you'd rather I did the squashing I'd be happy to do that as well.

TheLastProject commented 4 years ago

Don't really have the time to rebase and squash this any time soon so I'd prefer it if you would :)

forslund commented 4 years ago

Merged through #131, closing.

Awesome work, many thanks!