forslund / spotify-skill

Mycroft Skill to control spotify using the Spotify Connect API
Apache License 2.0
71 stars 38 forks source link

Increase the flexibility of artist regex #93

Closed augray closed 5 years ago

augray commented 5 years ago

I had a hard time getting this skill to play music by a requested artist. Some things I tried: "Play music by <artist> on Spotify" "Play songs by <artist> on Spotify" "Play <artist> on Spotify"

It would be helpful if more standard variations were supported for playing music by specific artists.

augray commented 5 years ago

Here's a PR if you want it: https://github.com/forslund/spotify-skill/pull/94

augray commented 5 years ago

The case "Play <artist> on Spotify" is obviously a bit more complex, and would likely need to be handled by a more sophisticated mechanism. So I left that one out.

forslund commented 5 years ago

94 Merged. Closing this Issue. Thank you very much for contributing :)

augray commented 5 years ago

No problem :+1: