search

forsys-sp / forsysr

An R implementation of the ForSys program
GNU General Public License v3.0
8 stars 3 forks source link

Patchmax fails lacking adjacency #76

Closed michelledayusfs closed 1 year ago

michelledayusfs commented 1 year ago

I can see that the old adj and dist parameters are no longer part of the patchmax call in ForSys (although they are not deleted from the @parameters. But I still get an error:

object 'adj_object' not found

michelledayusfs commented 1 year ago

I tried running it with the actual shapefile as the dataset: stand_data = shp, and by dropping the geometry, but both failed.

codyevers commented 1 year ago

Ok, I’ll investigate. Yes, patchmax does require the stand_data to be a sf object with geometry, unlike ForSysR which we specifically decided to make spatially agnostic. Also, yes, the adj_object and dist parameters are no longer required (they are calculated on the fly), so there should be no reference to either. I’ll comb the code and remove. On Jan 3, 2023 at 3:14 PM -0600, Michelle Day @.***>, wrote:

I tried running it with the actual shapefile as the dataset: stand_data = shp, and by dropping the geometry, but both failed. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>

michelledayusfs commented 1 year ago

testing_ForSysR_with_patchmax.zip

codyevers commented 1 year ago

Works on my end, which makes me think somehow patchmax is not updating. Try deleting the patchmax package and then reinstalling... On Jan 4, 2023 at 12:09 PM -0600, Michelle Day @.***>, wrote:

testing_ForSysR_with_patchmax.zip — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>

michelledayusfs commented 1 year ago

Still not working. I uninstalled and then ran the remotes code again. Should we pop on the forsys zoom call?

From: codyevers @.> Sent: Wednesday, January 4, 2023 10:35 AM To: forsys-sp/forsysr @.> Cc: Day, Michelle - FS @.>; Author @.> Subject: Re: [forsys-sp/forsysr] Patchmax fails lacking adjacency (Issue #76)

Works on my end, which makes me think somehow patchmax is not updating. Try deleting the patchmax package and then reinstalling... On Jan 4, 2023 at 12:09 PM -0600, Michelle Day @.***>, wrote:

testing_ForSysR_with_patchmax.zip

Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>

- Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fforsys-sp%2Fforsysr%2Fissues%2F76%23issuecomment-1371282172&data=05%7C01%7C%7Cf0a7ad4e8c76421bc08608daee826a2b%7Ced5b36e701ee4ebc867ee03cfa0d4697%7C0%7C0%7C638084541131688227%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jzJaHstT5TLTpFO1yc2ZVoVLji3a6932yxnIAQSX68Y%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASOH44AWQ4W6MNZBOWAKXXDWQW7F7ANCNFSM6AAAAAATQC7KWE&data=05%7C01%7C%7Cf0a7ad4e8c76421bc08608daee826a2b%7Ced5b36e701ee4ebc867ee03cfa0d4697%7C0%7C0%7C638084541131844976%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=an3O7QU%2BhjG8QEfpPv0TJQk4SZLvzUx6Ncx3bEZcHLU%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.

michelledayusfs commented 1 year ago

Uninstalled forsys and patchmax and then had to manually update vctrs. It is working now.