forsys-sp / forsysr

An R implementation of the ForSys program
GNU General Public License v3.0
8 stars 3 forks source link

Report ETrt_Yr only for ForSys with Fire #80

Open michelledayusfs opened 1 year ago

michelledayusfs commented 1 year ago

Is it possible to have ForSys only report ETrt_Yr when run_with_fire = TRUE.

It is a confusing output although this is not a big deal. Although if we had better documentation we could just explain that it is assuming all treatments happen in one year. But I'm assuming you cannot use this field EXCEPT when using run_with_fire

codyevers commented 1 year ago

To avoid some confusion, I've changed the name of fire_planning_years to planning_years, fire_annual_target_field to annual_target_field, fire_annual_target to annual_targetsince these aren't specific to forsys with fire, but rather if you want to set an annual limit on projects over a set time frame. This doesn't complete address the issue above, but at least makes clear this is a general parameter and not something specific to fire.

Keeping this open

codyevers commented 1 year ago

Going to leave this as a 'won't fix' for now given the way that forsys::run is structured around an annual loop. Easier to deal with this when/if we convert forsys into an object class