search

forsys-sp / forsysr

An R implementation of the ForSys program
GNU General Public License v3.0
8 stars 3 forks source link

ForSys project output missing area treated #81

Closed michelledayusfs closed 1 year ago

michelledayusfs commented 1 year ago

This is likely a patchmax issue- patchmax reports area treated and that is not being passed to ForSysR. (That is my guess).

run_outputs_single = forsys::run( return_outputs = TRUE, stand_data = shp, scenario_name = "patchmax_forsys_test", stand_id_field = "LMU_ID", stand_area_field = "Acres", stand_threshold = "Am4RevBio > 0", scenario_priorities = "Am4RevBio", scenario_output_fields = c("Am4RevBio", "prob_8p"), run_with_patchmax = TRUE, patchmax_proj_size = 500, patchmax_proj_number = 3, patchmax_SDW = 1, patchmax_EPW = 0 )

run_outputs_single$project_output does not return ETrt_Acres or Treat_Acres (not sure what the syntax is in forsys).

codyevers commented 1 year ago

@michelledayusfs, you get this informaiton if you add Acres to the vector of scenario_output_fields. I suppose we should add the stand_area_field to this vector so that this output is always apears?

codyevers commented 1 year ago

I just realized that this is probably relates to the #75 where selected but untreated stands are not being reported by Forsys when using patchmax.

michelledayusfs commented 1 year ago

Okay, but yes, I think it should be an automatic output. ForSys will always want to report "area treated."

codyevers commented 1 year ago

I made it so that area is always exported (assuming it's provided)

michelledayusfs commented 1 year ago

According to my parameter table, stand_area_field is required. Is this not the case?

michelledayusfs commented 1 year ago

ForSysX names this "Treat_Acres" but I like the consistency with the other metrics ("ETrt_Acres") so I like how this is now implemented.