search

fort-nix / nix-bitcoin

A collection of Nix packages and NixOS modules for easily installing full-featured Bitcoin nodes with an emphasis on security.
https://nixbitcoin.org
MIT License
513 stars 107 forks source link

update nixpkgs #711

Closed jonasnick closed 4 months ago

jonasnick commented 4 months ago

bitcoin: 27.0 -> 27.1 bitcoind: 27.0 -> 27.1 clightning: 24.02.2 -> 24.05 fulcrum: 1.10.0 -> 1.11.0 lnd: 0.17.5-beta -> 0.18.0-beta

The trustedcoin test scenario currently fails with error:

vm-test-run-nix-bitcoin-trustedcoin> machine # [    8.757348] lightningd[1084]: Wrong network! Our Bitcoin backend is running on '', but we expect 'regtest'.

This appears to be an issue in trustedcoin. CC @seberm

seberm commented 4 months ago

Hello @jonasnick , Is the trustedcoin scenario still failing? I noticed that all checks are passing in this PR. Could you guide me on how to reproduce the issue?

I tried running the tests locally, but I couldn't reproduce the problem:

git checkout update-nixpkgs63
cd tests
./run-tests.sh -s "trustedcoin"
erikarvstedt commented 4 months ago

Test trustedcoin works for me, too.

Here's a fix for the failing examples (covered by run-tests.sh all which includes run-tests.sh examples).

jonasnick commented 4 months ago

Hm, I can't reproduce the trustedcoin issue I had seen either. Sorry.

Thanks Erik for the fixups, for some reason I had only run ./run-tests.sh buildable.