Fix the CLI container to load the JSON RPC URL from env

[arbazkiraak]

There is a bug while reading up the environment variable for JSON RPC. The current implementation just checks the URL from forta.config.json but this adds the ability to load from the ENV variable.

Currently, all the environment HOST variables are defaulted to http:// , Can we moved them to https:// or just fully expect the jsonRPCUrl environment value instead of appending https://

[haseebrabbani]

hey @arbazkiraak appreciate the PR! the env var being used (JSON_RPC_HOST) is the one used by the scan node in production to inject its own RPC URL. for local development, you should just set jsonRpcUrl in forta.config.json file. if this does not meet your requirements, please let me know the specific scenario

[arbazkiraak]

Currently:

The way forta loads up the RPC endpoint is either via ENV or jsonRpcUrl in forta.config.json file

https://github.com/forta-network/forta-bot-sdk/blob/b521a2139a54f5d415eb214f08092bf77dba22a3/python-sdk/src/forta_agent/utils.py#L44

def get_json_rpc_url():
    if 'JSON_RPC_HOST' in os.environ:
        return f'https://{os.environ["JSON_RPC_HOST"]}{":"+os.environ["JSON_RPC_PORT"] if "JSON_RPC_PORT" in os.environ else ""}'

Reproduce the following:

• Do not set the jsonRpcUrl in forta.config.json file and run the node by following command.

JSON_RPC_HOST=https://arb-mainnet.g.alchemy.com/v2/<KEY> npm start

The Node by default with listen to the "https://cloudflare-eth.com/ because of the following condition

https://github.com/forta-network/forta-bot-sdk/blob/master/cli/di.container.ts#L248

---

• I think the advantage of passing out the RPC URL via the environment is , the users can use the same project code for running the bot on multiple chain RPC URL

[haseebrabbani]

to switch between multiple chains in the same project, the recommended way is to use the --config flag to select a different json config file (default is forta.config.json). see the CLI reference here: https://docs.forta.network/en/latest/cli/#run