forta-network / starter-kits

MIT License
66 stars 38 forks source link

FP on funding alert #354

Closed christian-forta closed 10 months ago

christian-forta commented 1 year ago

https://explorer.forta.network/alert/0x82903ccf3e95b7b88b53751c754caabe29e49a08afd4b8860b36ced2ea263ddc triggered, but the user wasnt new and previously funded

0xtaf commented 1 year ago

@christian-forta , I refactored this new account checker function from scratch. the bot now uses blockexplorer apis and checks if the account is younger than 5 days (this can be changed as you wish). in order for this bot to work, secrets.json must be placed into forta db. it's the same structure with the others (e.g. positive reputation bot)

{
  "apiKeys": {
    "ZETTABLOCK": "YourApiKeyToken",
    "ETHERSCAN_TOKEN": "YourApiKeyToken",
    "POLYGONSCAN_TOKEN": "YourApiKeyToken",
    "BSCSCAN_TOKEN": "YourApiKeyToken",
    "ARBISCAN_TOKEN": "YourApiKeyToken",
    "OPTIMISTICSCAN_TOKEN": "YourApiKeyToken",
    "FTMSCAN_TOKEN": "YourApiKeyToken",
    "SNOWTRACE_TOKEN": "YourApiKeyToken",
    "ALLIUM": "YourApiKeyToken",
    "MORALIS": "YourApiKeyToken"
  },
 }
christian-forta commented 12 months ago

secrets.json already has those keys; can you deploy the bot and close this bug?

christian-forta commented 11 months ago

has this been deployed yet? Can we close this issue, @0xtaf ?

0xtaf commented 10 months ago

Deployed in https://github.com/forta-network/starter-kits/pull/419