search

fortanix / rust-sgx

The Fortanix Rust Enclave Development Platform
https://edp.fortanix.com
Mozilla Public License 2.0
421 stars 99 forks source link

Removed unused error variants #621

Closed nshyrei closed 8 hours ago

nshyrei commented 1 week ago

Removes error variants that are no longer in use

nshyrei commented 1 week ago

@Raoul The OfflineAttestationError, BadRequest and PCSError are still used in PckCertApi (client/dcap_artifact_retrieval/src/provisioning_client/azure.rs:87 ). Is this functionality still needed?

nshyrei commented 6 days ago

@raoulstrackx Please review

raoulstrackx commented 5 days ago

The OfflineAttestationError error should also be removed. It doesn't convey any meaningful info. Worse, it doesn't even make sense if you get this error while doing online attestation. You'll need to come up with a better approach/name. BadRequest errors should also be removed as it can also be expressed as a PCSError with a status code, so that also doesn't make sense.

nshyrei commented 5 days ago

@raoulstrackx updated, please review.

nshyrei commented 1 day ago

@raoulstrackx updated, please review