search

fortesinformatica / Sideshow

Sideshow is a powerful javascript library which aims to reduce your user's learning curve by providing a way to create step-by-step interactive tours. Explain the features of your application, control your end-user's interaction with your UI, emphasize what you're explaining in each step by masking it. Just think! The sky is the limit!
http://fortesinformatica.github.io/Sideshow
Apache License 2.0
86 stars 31 forks source link

Replaced defineGetter with Object.defineProperty #5

Closed tonybaroneee closed 10 years ago

tonybaroneee commented 10 years ago

Object.defineProperty is a cleaner API for defining object properties, and has better cross-browser support (i.e. IE9, which I needed to support in a recent project using Sideshow). Refer to http://web.onassar.com/blog/2011/05/30/definegetter-definesetter-in-ie9/ for more info. Thanks!

alcidesqueiroz commented 10 years ago

Though I've never planned compatibility with IE9 (due to its lack of support for some important CSS3 features, e.g: animations and transitions, both used by Sideshow), this is a nice and simple fix. And besides, this fix is for a Sideshow dependency (Jazz.js, which don't have its own repository). I'll accept your pull request, and in the next version, this fix will be released, together with other fixes and improvements (probably this gonna be a minor version - 0.4.0, not just a simple patch). Best regards.

tonybaroneee commented 10 years ago

Much appreciated. And yeah, the framework runs really well on IE9 despite not having css3, so great work!