forthebadge / for-the-badge

It all started because of an obsession with two words: “build passing”. It all ended with this: badges, for badges’ sake.
https://forthebadge.com
GNU General Public License v3.0
1.8k stars 154 forks source link

Web Share API Share button is defaulting on some browsers and removing default shareable actions #264

Closed andrewsbarbaro closed 4 months ago

andrewsbarbaro commented 4 months ago

In some browsers, the web share API is available causing the 3 shareable actions buttons (copy PNG, copy SVG and copy Markdown) to be hidden in place of the share button.

The intention was to only active the web share API if the user is on a mobile device.

Reported by @tahayparker

andrewsbarbaro commented 4 months ago

@tahayparker Resolved! Added additional checks to ensure web share is only activated when viewing on a mobile device.

tahayparker commented 4 months ago

ooooo this was quickk thankss🙏🖤

tahayparker commented 4 months ago

forthebadge

tahayparker commented 4 months ago

couple more nitpicks if i may:

andrewsbarbaro commented 4 months ago

Thank you for this feedback! @tahayparker

  • the website signs you off pretty quick, any way to disable that?

We will investigate this and increase session length, thank you for this feedback.

  • there's no copy button for "my generated badges". if i lose the code, that color combination may never be remade :(

This is super important and we totally agree. We will include this in our next release.

  • for some weird reason changelogs has a permanent red dot on it, even after ive seen the changelog

This has been resolved in tonights release, another 🐞 squashed.

tahayparker commented 4 months ago

We will investigate this and increase session length, thank you for this feedback.

i think i fixed this, had to enable third party cookies because auth0 has the logins

feature request: let us add profile pics please (i like seeing the garfield pic everywhere)

andrewsbarbaro commented 4 months ago

Hey @tahayparker, Thanks so much for the feedback. We have added Profile Pics to our feature requests.

In the meantime, we just released some massive improvements to the "My Badges" page which include a few features that highlight some of your previous feedback! You are now able to view and copy each property of a previously generated badge. You can now also click the 'Edit with generator' button and you will be taken to the generator preloaded with the specific badge's properties.

Check it out and let us know what you think! Cheers 👏

Screenshot 2024-02-24 at 1 00 34 AM
tahayparker commented 4 months ago

this is soo coool mann i didnt expect this much tbh omw to make some badges now :) and thanks for considering profile pics!

tahayparker commented 4 months ago

small issue consider implementing a function that changes the color of the copy buttons when contrast isn't good enough for the buttons to be seen

image

tahayparker commented 4 months ago

please fix bottom whitespace here when there page is too short image

tahayparker commented 4 months ago

feature requests for "my badges":

andrewsbarbaro commented 4 months ago

please fix bottom whitespace here when there page is too short image

Fixed!

small issue consider implementing a function that changes the color of the copy buttons when contrast isn't good enough for the buttons to be seen

image

and Fixed!

tahayparker commented 4 months ago

https://forthebadge.com/images/badges/works-on-my-machine.png

This image is smaller than the rest I think it's been the same, before you took over, but it'd be great if it's fixed

The opposite is true for some other badges like this https://forthebadge.com/images/badges/powered-by-coders-sweat.svg

it's bigger than the rest is this a bug or a feature :)

andrewsbarbaro commented 4 months ago

https://forthebadge.com/images/badges/works-on-my-machine.png

This image is smaller than the rest I think it's been the same, before you took over, but it'd be great if it's fixed

The opposite is true for some other badges like this https://forthebadge.com/images/badges/powered-by-coders-sweat.svg

it's bigger than the rest is this a bug or a feature :)

We have been meaning to fix this for a while now but have just been focused on other features. I just fixed the sizing on both of these badges 😄 I invalidated our CDN so changes should take affect within 12 hours or on a cache clear!

tahayparker commented 4 months ago

it's working! 🥳🥳

tahayparker commented 4 months ago

found three more svgs with the same issue https://forthebadge.com/images/badges/contains-17-coffee-cups.svg https://forthebadge.com/images/badges/contains-breadcrumbs.svg https://forthebadge.com/images/badges/powered-by-pull-requests.svg

fix them whenever, im sure you have more important stuff going on (like that app coming out this spring, glad i checked linkedin)

andrewsbarbaro commented 4 months ago

found three more svgs with the same issue https://forthebadge.com/images/badges/contains-17-coffee-cups.svg https://forthebadge.com/images/badges/contains-breadcrumbs.svg https://forthebadge.com/images/badges/powered-by-pull-requests.svg

fix them whenever, im sure you have more important stuff going on (like that app coming out this spring, glad i checked linkedin)

Fixed!