search

fortheusers / hb-appstore

Homebrew App Store - GUI for downloading/managing homebrew apps
https://hb-app.store
GNU General Public License v3.0
1.08k stars 63 forks source link

Infinite scrolling on app info screen #110

Closed TheHighTide closed 5 months ago

TheHighTide commented 10 months ago

Describe the bug When I tap on an app in the app list and go to the screen that has all the info, I can scroll down infinitely. Even when I toggle expanded info it still does the same thing.

Platform: Wii U

To Reproduce

  1. Go to hbappstore on Wii U
  2. Click on any app
  3. Hold the DPAD DOWN button and watch all the contents leave the screen
vgmoose commented 10 months ago

Thanks, it's a bug with Chesto not having a southern bound on vertical scrollviews. We do know what the height of this pane should be, so it should be possible to have a stop there.

Worth noting though, that Chesto/hb-appstore's input priority are the touch controls, so if the southern boundary can't work in a satisfying way via touch then this might take longer to fix.

TheHighTide commented 10 months ago

Cool

On Fri, Nov 17, 2023 at 9:39 AM vgmoose @.***> wrote:

Thanks, it's a bug with Chesto not having a southern bound on vertical scrollviews. We do know what the height of this pane should be, so it should be possible to have a stop there.

Worth noting though, that Chesto/hb-appstore's input priority are the touch controls, so if the southern boundary can't work in a satisfying way via touch then this might take longer to fix satisfyingly.

— Reply to this email directly, view it on GitHub https://github.com/fortheusers/hb-appstore/issues/110#issuecomment-1816831203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUES5NAHSFT5IKRVMUUZHE3YE6OMRAVCNFSM6AAAAAA7HNMV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWHAZTCMRQGM . You are receiving this because you authored the thread.Message ID: @.***>

vgmoose commented 10 months ago

Okay, ended up just manually limiting the scroll on the app details page specifically, not in Chesto itself. Pages that are too short to scroll should also not scroll at all, unless read more is expanded.

Try on nightlies: https://nightly.link/fortheusers/hb-appstore/workflows/main/main

Leaving this issue open until the 2.4 release. Also there are cursor changes on both this screen and in the App list view, it animates while scrolling with the joystick now instead of flickering down. Hopefully this makes using the joystick to navigate feel better overall.

vgmoose commented 5 months ago

Actually, I am going to close this issue as 2.4 gets ready, to make it easier to track the open issues. If you're able, let me know if there's any issues with the new scrolling bounds (on both App list and App details).