search

fortheusers / hb-appstore

Homebrew App Store - GUI for downloading/managing homebrew apps
https://hb-app.store
GNU General Public License v3.0
1.08k stars 63 forks source link

Full Turkish Language Support #120

Closed MYusufY closed 5 months ago

MYusufY commented 5 months ago

I have been translating till like 5-6 hours, to make this good program even better :) Thanks for all of you guys! And also, i want to do other contribitions to HB app store, i dont want to just "translate" it. So if there is an idea about adding something to HB app store, im here :) I just want to contribute!!! Thanks again :)

vgmoose commented 5 months ago

Thank you! Looks good from what I can tell. I’ll merge this in shortly.

Were you able to test the changes in a custom build? I think it might make it easier if I add support for loading the ini from SD card to make translating easier.

MYusufY commented 5 months ago

Thanks! Thanks to you guys for this good program. I will test it in shortly 🙂 And yes, loading language .ini files might be pretty good to translators :) Maybe... this is the idea i want? Like i said, i need to do more contributions :) Thanks again 😊

MYusufY commented 5 months ago

And... if there is no problem, i have a simple question. How can the people download this version with Turkish language support after merging? In action tab, it gives linux, mac and windows apps only? And, is it directly going to homebrew app store as an update after merging or not? Thanks!

MYusufY commented 5 months ago

Also, i almost forgot to say, i had to change the "joke" part a little bit, because its not that "common" in our county, there can be misunderstoods :) So i made a "popular" one :) If you want to change it to original french fries anyways, i can do of course!

MYusufY commented 5 months ago

@vgmoose if there is anything you want to ask me about translation or change, feel free! Are you going to merge it? (Also, i did some small updates with one more commit. :) )

vgmoose commented 5 months ago

How can the people download this version with Turkish language support after merging?

The next version of hb-appstore will detect the wiiu/switch system language, and allow the user to override it in settings, but I am still working on this.

Changing the joke is totally fine, I think it's a nice touch that translators will be able to pick their own "proverb" for that error screen / recovery mode!

I'm merging it now, and you can expect it to be in the next 2.4 version of hb-appstore. This was supposed to come out end of April but has been pushed back. These are the remaining tasks: https://github.com/fortheusers/hb-appstore/issues?q=is%3Aopen+is%3Aissue+label%3A2.4-release

MYusufY commented 5 months ago

@vgmoose thanks a lot for all of these informations and also sorry for too many questions ☺️