search

fortheusers / hb-appstore

Homebrew App Store - GUI for downloading/managing homebrew apps
https://hb-app.store
GNU General Public License v3.0
1.08k stars 64 forks source link

Use libcurl instead of hacky HTTP download code #2

Closed vgmoose closed 6 years ago

vgmoose commented 6 years ago

In Utils.cpp, on Switch targets, libcurl isn't able to be used. This results in slower, unreliable http download code.

vgmoose commented 6 years ago

There's a libcurl portlib available on dkp-pacman, but using it results in the following compilation error:

/opt/devkitpro/portlibs/switch/lib/libcurl.a(libcurl_la-mime.o): In function curl_mime_filedata':
mime.c:(.text+0x1a50): undefined reference toaccess'
/opt/devkitpro/portlibs/switch/lib/libcurl.a(libcurl_la-timeval.o): In function Curl_now':
timeval.c:(.text+0x10): undefined reference toclock_gettime'
collect2: error: ld returned 1 exit status
make[1]:  Error 1
Black-Seraph commented 6 years ago

What's your problem exactly? Removed the -DNOCURL flag, added -lcurl, and all builds flawlessly and works fine.

vgmoose commented 6 years ago

You're right! It used to be crashing my Switch (after resolving the above mentioned build problems) but with the latest libcurl package everything looks good.

Removed NOCURL code from https://github.com/vgmoose/get/commit/2338da592f3e874cda1f6bd6d060c06327d8dcd7 Updated progress bar to use curl's progress callback: https://github.com/vgmoose/appstorenx/commit/023373a60040ab45edb4e882c8f58232f74be86a