fortheusers / hb-appstore

Homebrew App Store - GUI for downloading/managing homebrew apps
https://hb-app.store
GNU General Public License v3.0
1.02k stars 60 forks source link

Custom Background music doesn't work #87

Closed danylopez123 closed 1 year ago

danylopez123 commented 1 year ago

Describe the bug As the README.md said down, you can have custom musics for the App Store I did that, searched for an .mp3 file, renambed it as background.mp3 and added it to sd:/wiiu/apps/appstore/background.mp3 And just to be sure, i re-downloaded the appstore to make sure i stay with the latest release version.

Platform: Wii U (EUR/PAL) with the Tiramisu hack method.

To Reproduce

  1. Search for a mp3 music you want or make your own.
  2. Rename it as background.mp3
  3. Place it to sd:/wiiu/apps/appstore/
  4. Launch the App Store.
  5. Music still the same.
doritobob269 commented 1 year ago

I can confirm I'm having the exact same issue on Wii U (USA/NTSC) with Tiramisu. Oddly enough I was trying this exact same thing at the same time!

vgmoose commented 1 year ago

You are both fast! That part of the readme was just added and is referring to an upcoming unreleased build, which can be downloaded from CI here: https://github.com/fortheusers/hb-appstore/actions/runs/3009555813 as either a wuhb, rpx, or nro. (If you do run this pre-release version, it will say there's an update available for itself, ignore that).

These changes are going to be released in the next day or two as v2.3, let me know if you do try them and if there are any issues.

doritobob269 commented 1 year ago

The background music works! Here's video proof. https://i.imgur.com/MxIdaCN.mp4 Also shown in the video is the app crashing when I pressed the (-) to quit. I'm using the .rpx version, installed in the /wiiu/apps/appstore folder of an existing hb-appstore install, and loaded through homebrew launcher.

vgmoose commented 1 year ago

Can you try this build? https://github.com/fortheusers/hb-appstore/actions/runs/3018646768

Thanks for testing, there's three ways to exit the app: home menu -> exit, quit button (touch), pressing minus, and that last one should be fixed now.

doritobob269 commented 1 year ago

Home button doesn't open the home menu so I can't test for that. Touching quit button works. Pressing minus work! Thanks so much! This is so cool!

danylopez123 commented 1 year ago

I've tested this using https://github.com/fortheusers/hb-appstore/actions/runs/3022542061 The music works fine now, however, when i try to quit the appstore, it just boots back to the Wii U menu and not the Homebrew screen.

vgmoose commented 1 year ago

That is likely the behavior going forwards, as Aroma rolls out. This the mechanism that official Wii U apps use to exit (or that's my understanding).

EnforcerRidley commented 1 year ago

On this new version (for the Switch), down on the D-pad doesn't work, though the control stick does work. Quitting the app also goes to a blank screen, having to press home and close the app with X.

vgmoose commented 1 year ago

Does the D-pad thing still occur in this build? https://github.com/fortheusers/hb-appstore/actions/runs/3043040002

Currently trying to resolve the exiting issue. It is likely a result of some file handle that was left open.

EnforcerRidley commented 1 year ago

The D-pad for the Switch version is working now. I'm seeing no issues. Thank you!

But something I noticed after posting my last comment. Neither the control stick nor the D-pad for the 3DS version are working. Ordinarily, this wouldn't be a problem for the 3DS, however, the top row of apps is also on the upper screen which isn't a touchpad so cannot be selected or is super hard to select (requires Sorting and hoping the app you want on the upper screen is sorted on another row you can get).

I'm assuming that the 3DS version is experimental at this point of time? The 3DS version also doesn't have support for BG music currently?

vgmoose commented 1 year ago

Yep, the 3DS is very experimental at this time. I'm going to focus more on it after this latest Switch/Wii U release round.

The main reason the 3DS and Wii builds don't currently support music is that they're using SDL1 instead of SDL2. Not that it's impossible on SDL1, just that the same wrappers/code haven't been implemented in Chesto.

vgmoose commented 1 year ago

Fixed in 2.3.1