search

fortify / fcli

fcli is a command-line utility for interacting with various Fortify products
https://fortify.github.io/fcli/
Other
31 stars 22 forks source link

Code quality: Add request parameters using unirest.routeParam() instead of string concatenation #27

Closed gendry-gh closed 2 years ago

gendry-gh commented 2 years ago

as seen in https://github.com/fortify-ps/fcli/blob/3279ccec8bb97c8af43caa5ece0d2f8ab2bc9a73/fcli-ssc/src/main/java/com/fortify/cli/ssc/picocli/command/crud/get/version/SSCGetVersionAttributesCommand.java#L55

rsenden commented 2 years ago

Removed 'bug' label, as this is not really a bug but just a possible code improvement without any functional impact.

rsenden commented 2 years ago

Should now have been implemented wherever appropriate; in some places we still use string concatenation/replacement for valid reasons