Closed kadraman closed 1 year ago
Traced this done to fod-export\action.yml
. It is not quoting the app:release
name for --fod.release.name
:
...
''|*[!0-9]*) echo '_RELEASE_OPT="--fod.release.name=${FOD_RELEASE}"' >> $GITHUB_ENV ;;
...
This should probably be:
...
''|*[!0-9]*) echo '_RELEASE_OPT=--fod.release.name="'${FOD_RELEASE}'"' >> $GITHUB_ENV ;;
...
The same applies to ssc-export\action.yml
Turns out that the GitHub @actions\exec
code being used swallows up any double quotes, so replaced with triple single quotes '''
and it now works.
''|*[!0-9]*) echo '_RELEASE_OPT=--fod.release.name='''${FOD_RELEASE}'''' >> $GITHUB_ENV ;;
and similar for SSC.
Note: behaviour of FortifyVulnerabilityExport
when application name has spaces in should be looked at. It should be failing not really trying to export the data for all releases (unless an explicit option to do this is set).
Fixed in c04ac28398685799fb76a7b02acbcb18af034231
Given the following:
if
inpus.fod_app_name
is "IWA-Java [KAL]" andinputs.fod_release_name
is "main" the resultantFOD_RELEASE
will be'IWA-Java [KAL}:main'
(including single quotes). This should work fine.However, the
fod-export
action doesn't see this and ends up trying to export all of the vulnerabilities for each release under "IWA-Java [KAL]".Workaround is to use
FOD_RELEASE
with release id - the value of which can be retrieved using "fcli":Note: the
ssc-export
as well asfod-sast-scan
andsc-sast-scan
might exhibit the same behaviour.