fortinet-ansible-dev / ansible-galaxy-fortimanager-collection

GNU General Public License v3.0
16 stars 16 forks source link

Collection Requirements Violation - Repository Management #53

Closed gotmax23 closed 1 year ago

gotmax23 commented 2 years ago

Hi! The Ansible Community Steering Committee has determined that this collection does not tag its releases in its git repository. This violates the repository management section of the Collection Requirements:

Every collection MUST have a public git repository. Releases of the collection MUST be tagged in said repository. This means that releases MUST be git taged and that the tag name MUST exactly match the Galaxy version number. Tag names MAY have a v prefix, but a collection's tag names MUST have a consistent format from release to release.

Additionally, collection artifacts released to Galaxy MUST be built from the sources that are tagged in the collection's git repository as that release. Any changes made during the build process MUST be clearly documented so the collection artifact can be reproduced.

Note that this requirement has recently been clarified, but its intent remains the same. Please tag at least the previous 1-2 releases of your collection to come into compliance. I understand that this collection currently stores each release in a separate branch, but that does not meet this requirement.

Please keep us updated and let us know if you have any questions. Thanks!

lix-fortinet commented 2 years ago

Hi @gotmax23,

Thank you for your notification. We will update it.

Thanks, Xing

gotmax23 commented 2 years ago

Great! Please also git tag the last two releases of this collection.

lix-fortinet commented 2 years ago

Sure, no problem.

Thanks, Xing

gotmax23 commented 1 year ago

@lix-fortinet, has there been any progress here? It looks like this was fixed for fortinet.fortios but not for this collection.

chillancezen commented 1 year ago

@gotmax23 thanks Max, I will be doing this today.~

gotmax23 commented 1 year ago

It looks like 2.1.7 has been tagged as https://github.com/fortinet-ansible-dev/ansible-galaxy-fortimanager-collection/releases/tag/2.1.7. Thank you for fixing this!