search

fortra / impacket

Impacket is a collection of Python classes for working with network protocols.
https://www.coresecurity.com
Other
13.49k stars 3.57k forks source link

Unnecessary dependency on future #1584

Closed frenzymadness closed 1 year ago

frenzymadness commented 1 year ago

Hello. It seems to me that the dependency on future does not need to be there:

https://github.com/fortra/impacket/blob/fdbd25684fe528f9b6f910e7a5ef4b33ea96defa/setup.py#L71

I cannot find any usages of future lib in the project. My motivation to check it was that the future library is broken with Python 3.12 and will be more with 3.13.

gabrielg5 commented 1 year ago

Closed in #1598