search

fortra / impacket

Impacket is a collection of Python classes for working with network protocols.
https://www.coresecurity.com
Other
12.99k stars 3.5k forks source link

update requirements.txt in order to drop of python2 support #1681

Open NtAlexio2 opened 5 months ago

NtAlexio2 commented 5 months ago

This PR is fully about windows environment.

pyreadline module is not supporting new versions of python 3.x, as specified in documentation here: Version 2.1 of pyreadline has been verfied for Python 2.7, and 3.4, 3.5.

Since Impacket continues growing by Python3, we need to update dependencies (requirements.txt). pyreadline3 is the new version of its previous version and supports more recent versions of python3, as specifications in document.

anadrianmanrique commented 5 months ago

Thanks for the clarification. We will review this one for sure, as we suspect that pyreadline is not being currently used in the project (despite being referenced in the code and dependencies.. ).