search

fortra / impacket

Impacket is a collection of Python classes for working with network protocols.
https://www.coresecurity.com
Other
12.99k stars 3.5k forks source link

Cleanup #1689

Open xambroz opened 5 months ago

xambroz commented 5 months ago

cleanup based on the rpmlint check 1) set library modules as non-executable as there is no main functionality and is meant to be used only via import impacket/examples/ldap_shell.py impacket/examples/smbclient.py 2) convert ends of lines from windows to unix (as rest of the project) for the file impacket/examples/mssqlshell.py 3) remove unnecessary shebang for impacket/examples/mssqlshell.py

rpmlint ~/rpmbuild/RPMS/noarch/python3-impacket-0.11.0-3.fc39.noarch.rpm ... python3-impacket.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.12/site-packages/impacket/examples/mssqlshell.py python3-impacket.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/impacket/examples/mssqlshell.py 644 /usr/bin/python3 -sP

anadrianmanrique commented 5 months ago

Hi, thanks for the PR. We are not merging mssqlshell.py, as changes will make to loose the files changes history and won't be able to track previous changes. Please remove mssqshell.py ( or revert the EOL changes ) from the PR, so we can merge it. Thanks