search

fortra / impacket

Impacket is a collection of Python classes for working with network protocols.
https://www.coresecurity.com
Other
12.99k stars 3.5k forks source link

ADCS PKCS#12 clarification and formatting #1692

Closed Ernesto-Alvarez closed 2 months ago

Ernesto-Alvarez commented 5 months ago

Slight clarification of what data is being returned on ADCS attack Patch ADCS attack to limit line length on PKCS#12 data returned (to prevent clipboard problems w/overly long lines)

anadrianmanrique commented 5 months ago

Hi! thanks for the PR. We were discussing about certificate output for ADCS. We think it would be nice to be consistent, and have for both, shadow credentials and ADCS , certificates dumped as files ( instead stdout for one and file for the other ) One item of this PR contemplates this https://github.com/fortra/impacket/pull/1439 Let us know your thoughts

anadrianmanrique commented 5 months ago

see also https://github.com/fortra/impacket/pull/1440

anadrianmanrique commented 2 months ago

Closing this one. Changes related to this :