search

fortra / impacket

Impacket is a collection of Python classes for working with network protocols.
https://www.coresecurity.com
Other
12.99k stars 3.5k forks source link

LDAP Channel binding implementation #1697

Open FrankSpierings opened 5 months ago

FrankSpierings commented 5 months ago

Implemented LDAP channel binding as cleanly as I could, based on https://github.com/ly4k/ldap3.

The fact that I had to add a parameter to computeResponse/computeResponseNTLMv2/getNTLMSSPType3, is not great.

This works for GetUserSPNs.py, since it uses Impackets version of ldap.py. I have seen that addcomputer.py uses https://github.com/cannatag/ldap3. So that stills needs work.

anadrianmanrique commented 2 months ago

@FrankSpierings Hi, I'm reviewing your changes. So far, code seems to work as expected. I suggested some minor changes in the code. In order to approve the PR those should be applied. Thanks!

FrankSpierings commented 2 months ago

@FrankSpierings Hi, I'm reviewing your changes. So far, code seems to work as expected. I suggested some minor changes in the code. In order to approve the PR those should be applied. Thanks!

I might be a n00b; but I don't see your suggestions. Should these just show up in my pull request?

anadrianmanrique commented 2 months ago

@FrankSpierings sorry, my bad, please check now