Closed p0dalirius closed 1 month ago
Hi @p0dalirius,
Checking your changes I found a path that is triggering an error when generating the output.
This line is not setting any value to the new column https://github.com/fortra/impacket/blob/269ce69872f0e8f2188a80addb0c39fedfa6dcb8/examples/findDelegation.py#L228
which is resulting in an exception iterating rows to draw the table https://github.com/fortra/impacket/blob/269ce69872f0e8f2188a80addb0c39fedfa6dcb8/examples/findDelegation.py#L40-L44
Also, could you revert those quoting changes? that makes the PR more atomic and helps validate what is the real change
thank you!!
Hi @gabrielg5,
I have fixed the code path
I have reverted the quoting changes, although the code really should be double quoted and not single quoted everywhere.
Best regards,
Hey @p0dalirius,
great! just one last ask before merging this PR... Can you extract the spnExists
resolution to an external function to avoid duplicating those lines?
thank you!
Done :)
Merging now.. Thank you!
Hi,
I have added a new column "SPN Exists" to easily see if SPN Jacking is possible.
Here is a redacted example of output:![image](https://github.com/fortra/impacket/assets/79218792/37ba9250-ce65-4ee1-8c48-4479e95cc01c)
Best regards,