search

fortra / impacket

Impacket is a collection of Python classes for working with network protocols.
https://www.coresecurity.com
Other
13.37k stars 3.56k forks source link

SMB: Missing out of memory error handling 0x17000000 #1733

Closed nikaiw closed 5 months ago

nikaiw commented 5 months ago

as describe in https://github.com/Pennyw0rth/NetExec/issues/258 , impacket/nt_errors.py seems to be missing the value 0x17000000 for handling what seems to be "out of memory" server error.

image

anadrianmanrique commented 5 months ago

according to https://github.com/Pennyw0rth/NetExec/issues/258 ( altough it hasn't been specified ) I can infer impacket 0.11 it's being used in that scanrio. Changes related to NTSTATUS error handling were merged in order to handle unknown values at https://github.com/fortra/impacket/pull/1311. Please confirm wether the issue is still present in the master branch Thanks

mpgn commented 5 months ago

The PR you mention has been reverted https://github.com/fortra/impacket/pull/1714 so yes the issue is on master branch :)

anadrianmanrique commented 5 months ago

Nope, changes were not reverted. https://github.com/fortra/impacket/blob/master/impacket/smb.py#L582 . In https://github.com/fortra/impacket/commit/0d2b72ae979bebaf8167a9bafa597fa1a0a6bfb5 we kept the older interface in order to avoid crashes in your code. Please recheck

anadrianmanrique commented 5 months ago

setting this as duplicate https://github.com/fortra/impacket/issues/1603 closing. Please reopen if needed