search

fortrabbit / craft-object-storage

A Craft 3 plugin that integrates with fortrabbit's S3 compatible Object Storage
MIT License
3 stars 8 forks source link

Field Layout is dropped when Installing #4

Closed jbutts-nerdery closed 4 years ago

jbutts-nerdery commented 4 years ago

Hello!

When installing the v1.0.3.1 of fortrabbit Object Storage Volume on Craft 3.3.17, the Asset volumes convert from "Amazon S3" to "fortrabbit Object Storage" as expected, but the field layout options get reset. The data still exists, so I'm wondering if this could be reconnected during the afterInstall event within the plugin.

Thanks for your consideration!

ostark commented 4 years ago

from "Amazon S3" to "fortrabbit Object Storage" as expected

Did you upgrade from Craft 2 to 3?

Can you tell me what "field layout options" are? What is the expected and what's the actual state?

jbutts-nerdery commented 4 years ago

Yes, we are upgrading from 2 to 3, but the disconnect seems to happen specifically when installing the plugin with volumes.php configurations matching existing S3 buckets. Field layout options are the assigned fields for each Asset Volume. I'm attaching screenshots of the expected and actual states. This view occurs after selecting a volume from /admin/settings/assets

Expected/Pre-install expected

Actual/Post-install actual

Thanks Oli!

ostark commented 4 years ago

I see - in Craft2 the assetsources.type (volumes assetsources, type field) was S3. Those are migrated to volumes.type craft\awss3\Volume - right?

The new volumes.type for the Object Storage is fortrabbit\ObjectStorage\Volume. As the volumes.handle is not unique an automate migration is not possible.

Manually changing the ids would work, but it is a bit hacky. A proper migration would be good, right? Since the fields and values are just assumptions, it would be good to see the contents of the volumes table. Feel free to use our support chat to share it and reference this issue.

jbutts-nerdery commented 4 years ago

Thanks Oli! I'll reach out in the support chat.

jbutts-nerdery commented 4 years ago

Resolved in 1.1.0, thank you!