search

fortrabbit / craft-object-storage

A Craft 3 plugin that integrates with fortrabbit's S3 compatible Object Storage
MIT License
3 stars 8 forks source link

enable usePathStyleEndpoint config #5

Closed mark-wff closed 8 months ago

mark-wff commented 4 years ago

To use this plugin with different S3 implementations I needed this configuration option. Maybe you should enter a default value. But here I am not sure where you would do this.

ostark commented 4 years ago

Hi Mark, can you please elaborate?

mark-wff commented 4 years ago

I use the following docker image in my local development environment: https://github.com/gaul/s3proxy.

This implementation uses a "Path Style Endpoint". With a path style endpoint, the bucket is not a subdomain, but the first parameter in path. testbucket.s3.example -> s3.example/testbucket. The S3Client offers this as configuration: https://docs.aws.amazon.com/aws-sdk-php/v3/api/class-Aws.S3.S3Client.html#___construct

Your libary did not have the possibility to do this configuration.

approached commented 3 years ago

Thank you for your PR. Maybe it's time to fork this Project.