search

fortran-lang / fftpack

Double precision version of fftpack
https://fortran-lang.github.io/fftpack/
Other
68 stars 19 forks source link

Create initial version #8

Closed awvwgk closed 3 years ago

awvwgk commented 3 years ago

Do you think it would be useful to tag the initial version of this project? Maybe the use the first commit that works with fpm for this purpose. Even if it is only used a fixed reference point to compare against future version, for reasons of API and ABI compatibility.

certik commented 3 years ago

Yes! Which commit is the first one that works with fpm?

zoziha commented 3 years ago

image

Both of two are the first support for fpm.

awvwgk commented 3 years ago

a8f7ae8 would be the first in the main line here to tag as release.

awvwgk commented 3 years ago

Any update on this?

zoziha commented 3 years ago

I have nothing to update :)

awvwgk commented 3 years ago

Let me rephrase, is there any concern about tagging https://github.com/fortran-lang/fftpack/commit/a8f7ae8e607f305de6d93143d9dec5eaa06d53aa as v4.0.0?

zoziha commented 3 years ago

I think it is OK. This submission a8f7ae8 only changed the structure of the file folders and added fpm support, and the Fortran code was unchanged.

Previously in netlib, this fftpack was called dfftpack 1.0, based on fftpack 4. (see doc/README in fortran-lang/fftpack)

                        DFFTPACK V1.0
*****************************************************************
        A Double precision clone by Hugh C. Pumphrey  of:
                      FFTPACK
               version 4  april 1985
certik commented 3 years ago

So I think using v4.0.0 should work.

awvwgk commented 3 years ago

Alright, I pushed the tag and created a release for it.

certik commented 3 years ago

Thanks!