search

fortran-lang / fortls

fortls - Fortran Language Server
https://fortls.fortran-lang.org/
MIT License
258 stars 41 forks source link

Issue #284 fix and extend hover of parameters. #288

Closed folk85 closed 1 year ago

folk85 commented 1 year ago

Modify regex of parameter's values. Add division sign, allow spaces in values of parameters. Extend unittests with parameters variables.

@gnikit

gnikit commented 1 year ago

Cheers for the PR @folk85, I approved the runs and will have a look at it today. But in general it looks good.

codecov[bot] commented 1 year ago

Codecov Report

Merging #288 (6debd0e) into master (b604730) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          12       12           
  Lines        4569     4569           
=======================================
  Hits         3973     3973           
  Misses        596      596
Impacted Files Coverage Δ
fortls/regex_patterns.py 100.00% <100.00%> (ø)
folk85 commented 1 year ago

@gnikit , thanks for the fast response. I also thought about many whitespaces, but I think it should be in separate issue and I have idea how to solve it.