fortran-lang / fortls

fortls - Fortran Language Server
https://fortls.fortran-lang.org/
MIT License
257 stars 41 forks source link

Allow dollar in symbol names #351

Closed emanspeaks closed 10 months ago

emanspeaks commented 10 months ago

Some language dialects allow dollar signs in symbol names. In Intel, this is always allowed. In g77, it can be enabled via command line flag. This seems to be an older practice that has fallen out of favor and was always a language extension, but is needed to support backward compatibility with older codes.

I've opted to implement this as always allowed like the Intel implementation, but I can change this to be an opt-in feature if we'd rather. I don't suspect it will hurt anyone to allow it.

There are other noted historical uses of $ in Fortran that are more rare, particularly with different variations of write statements, but it is unclear if any of these are still supported today by any compilers. (Even if they are, the current proposed regex is unlikely to erroneously match to them.)

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8466034) 87.52% compared to head (7a31879) 87.52%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #351 +/- ## ======================================= Coverage 87.52% 87.52% ======================================= Files 35 35 Lines 4760 4760 ======================================= Hits 4166 4166 Misses 594 594 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.