search

fortran-lang / fpm

Fortran Package Manager (fpm)
https://fpm.fortran-lang.org
MIT License
844 stars 95 forks source link

fix: add fpm_model.json to the package tarball before uploading to the registry #1010

Closed henilp105 closed 3 months ago

henilp105 commented 3 months ago

This PR introduces a bug fix to attach a fpm_model.json file , this bug has been patched in an interim manner in the registry repo: https://github.com/fortran-lang/registry/pull/75 .

Thanks and Regards, Henil

gnikit commented 3 months ago

@henilp105 does this affect any other fpm activity? As in, do we call git_archive in any a context other than the registry integration at the moment?

henilp105 commented 3 months ago

@gnikit No, The git_archive functionality is only used to publish a tarball to the registry. This bug doesn't affect any other fpm functionality. the tarball uploaded on the registry must contain a fpm_model.json file, which was not getting attached in v0.10.1 to handle this in an interim manner a patch https://github.com/fortran-lang/registry/pull/75 has been made on the registry side to generate and attach the fpm_model.json file to the tarball on the server side, This is a permanent fix for the bug.

perazz commented 3 months ago

My edit reflects @gnikit (and my) concern to not lose the option to call git_archive from elsewhere. LGTM with this edit, let's see what Giannis thinks.

henilp105 commented 3 months ago

Thanks @perazz for fixing this.