Enable CI via GH actions

fortran-lang / fprettify

auto-formatter for modern fortran source code

https://pypi.python.org/pypi/fprettify

Other

368 stars 73 forks source link

Enable CI via GH actions #129

Closed awvwgk closed 1 year ago

awvwgk commented 1 year ago

Python 3.5 / 3.6 using preinstalled Python versions on runner
Python 3.7 to 3.10 using conda-forge Python

TODO

[x] coverage upload to coveralls
[x] pypi upload (different workflow?)

Closes pseewald/fprettify#128

gnikit commented 1 year ago

I would do codecov.io instead of coveralls and for PyPi we can copy this https://github.com/gnikit/fortls/blob/master/.github/workflows/python-publish.yml but we will have to get @pseewald to upload the tokens as secrets to the repo.

gnikit commented 1 year ago

Also, we might want to consider first swapping to setup.cfg, pyproject.toml, setup.py 3-file stubs and reshaping the testing (not in this PR though)

awvwgk commented 1 year ago

I would do codecov.io instead of coveralls

It looks like this project originally used coveralls, I would be fine with switching to codecov as well. @pseewald any preference?

Also, we might want to consider first swapping to setup.cfg, pyproject.toml, setup.py 3-file stubs and reshaping the testing

Let's get the CI running first before we start changing things.

gnikit commented 1 year ago

~~We might have to go and fetch the test data from the outside repos manually from the git history. I can't find all the tarball archives cp2k, cron, FLAP, rosseta, etc.~~ Sorry my bad, I was looking at the wrong place.

We don't have to fetch the tarballs, we can just clone I recon.

awvwgk commented 1 year ago

We might have to go and fetch the test data from the outside repos manually from the git history. I can't find all the tarball archives cp2k, cron, FLAP, rosseta, etc.

They are fetched via git-archive tarballs from the fprettify-test branch in @pseewald's forks of the respective projects.

pseewald commented 1 year ago

@awvwgk @gnikit Thanks a lot of taking care of this, great work! Sorry for replying late.

I would be fine with switching to codecov as well. @pseewald any preference?

I have no preference due to lack of experience regarding these tools, please use whatever you prefer.

We might have to go and fetch the test data from the outside repos manually from the git history. I can't find all the tarball archives cp2k, cron, FLAP, rosseta, etc.

Sorry for this cumbersome mechanism, I'll soon make a pr for #140 where I change the way external Fortran code is added for tests. I also suggest that we use the official repositories instead of custom forks (I'll also take care of this in #140).

gnikit commented 1 year ago

Sorry for this cumbersome mechanism, I'll soon make a pr for #140 where I change the way external Fortran code is added for tests. I also suggest that we use the official repositories instead of custom forks (I'll also take care of this in #140).

Thanks for taking care of this @pseewald, that's great!