search

fortran-lang / fprettify

auto-formatter for modern fortran source code
https://pypi.python.org/pypi/fprettify
Other
368 stars 73 forks source link

Support the letters q and Q. #145

Open kohei-noda-qcrg opened 1 year ago

kohei-noda-qcrg commented 1 year ago

It is the implementation and its testing to resolve #144

Supports quadruple_precision expressions such as r = 1.0Q-10

kohei-noda-qcrg commented 1 year ago

@gnikit @awvwgk Could you review if this feature is needed and its implementation?

kohei-noda-qcrg commented 1 year ago

@awvwgk Some CIs failed, but the reason is due to the version of the ubuntu OS used in the test.

OS version

https://github.com/pseewald/fprettify/actions/runs/4161587117/jobs/7669164318#step:1:4 ubuntu-latest means ubuntu-22.04 LTS

Requirements for the failed test

https://github.com/pseewald/fprettify/blob/f5061b53459e1910c39a2b295c937624763ab15e/.github/workflows/test.yml#L88 pip workflows requires python 3.5 and 3.6.

Reasons for failure

https://github.com/actions/setup-python/issues/544 However, according to this issue, ubuntu-22.04 LTS no longer supports python version ≤ 3.6.

Solution

I think there are two options to solve this problem

  1. Temporary use ubuntu-20.04 image for CI.
  2. use python version ≥ 3.7 for CI.

How should we solve this problem?

gnikit commented 1 year ago

We have some PRs in the pipeline updating the CI.

kohei-noda-qcrg commented 1 year ago

@gnikit I see. I checked #135 is the pipeline upgrade pull request.

kohei-noda-qcrg commented 1 year ago

Sure. I will rebase this pr to the latest master branch.

kohei-noda-qcrg commented 1 year ago

@gnikit I rebased this pull request to the latest master branch.