fortran-lang / minpack

Modernized Minpack: for solving nonlinear equations and nonlinear least squares problems
https://fortran-lang.github.io/minpack/
Other
96 stars 20 forks source link

Port features from certik/minpack #22

Open certik opened 2 years ago

certik commented 2 years ago

I have archived the https://github.com/certik/minpack repository and moved the open issue from there to here. What remains is to port all the improvements that were implemented there over to this repository.

The tree from the other repo is available at https://github.com/fortran-lang/minpack/tree/c0dc9cd as well.

ivan-pi commented 2 years ago

Here's a small batch of commits I looked at:

bilderbuchi commented 2 years ago

I'm not sure if you're aware, but there seems to be another modernised F90 version by John Burkardt around, not sure if that could be useful when comparing different implementations or so? https://people.sc.fsu.edu/~jburkardt/f_src/minpack/minpack.html

jacobwilliams commented 2 years ago

I don't think we need it for anything. We tested the refactored version against the original one and made sure the results were the same. I think ours is superior to other refactoring attempts I've seen for various reasons (ours is in a module so we get interface checking, permissive license, more effective refactoring/goto removals/etc, all real constants use the kind parameter rather than D0, fully integrated with the Fortran Package Manager, etc.)