search

fortran-lang / registry

Registry for Fortran package manager
MIT License
8 stars 3 forks source link

feat: added the UI for Home Page. #23

Closed arteevraina closed 1 year ago

arteevraina commented 1 year ago
minhqdao commented 1 year ago

Please provide a url to the updated homepage in the PR description so we can test it.

arteevraina commented 1 year ago

@minhqdao https://registry-frontend.vercel.app/

minhqdao commented 1 year ago

The enter key now works on the homepage, but once you searched sth and the search bar moves to the top, the enter key stops working.

minhqdao commented 1 year ago

When I start a search from the homepage, there is a loading indicator. But once the search bar moves to the top and I search for packages again, there is none. Seems like some business logic isn't reused here. 🤔

minhqdao commented 1 year ago

When I search for asdf, then go the homepage again via the fpm icon and search for fpm, then the old results are shown just quickly. It's not super important but I think the state should be resetted before the navigation (actually it should be coupled with the display of the loading indicator screen).

henilp105 commented 1 year ago

Thanks for the suggestions , @minhqdao I have fixed them in my fork , will be fixed in upcoming PR.

henilp105 commented 1 year ago

Thanks @arteevraina , just a few suggestions above rest Looks good to me.

arteevraina commented 1 year ago

The enter key now works on the homepage, but once you searched sth and the search bar moves to the top, the enter key stops working.

Thanks for mentioning this @minhqdao . It has been already fixed by @henilp105 in this https://github.com/fortran-lang/registry/pull/22/commits/8b167ada37b2d0d79a093eb99e86b5f4f6725adf. Unfortunately, this commit is not in my branch because it was created before this commit was merged. So, I can confirm this issue has already been fixed in main branch,

arteevraina commented 1 year ago

When I start a search from the homepage, there is a loading indicator. But once the search bar moves to the top and I search for packages again, there is none. Seems like some business logic isn't reused here. 🤔

This has been fixed in this commit https://github.com/fortran-lang/registry/pull/23/commits/6cc5275f2af8edf613ea7b5215b3f86756bc5f64.