Closed henilp105 closed 1 year ago
@henilp105 Is this read for review again ?
yes @arteevraina
I am still able to reproduce the above mentioned issues in this link https://registry-phi.vercel.app/. Isn't this the updated one ?
Sure @arteevraina , I had forgot to update the deployment. I have now updated it. here is the updated link: https://registry-phi.vercel.app/
@henilp105 I tried the PR locally. It seems that it has improved a lot as per the last comments. Good work.
I noticed some more issues which I think are quick to fix -
Can you rename github actions file https://github.com/fortran-lang/registry/pull/28/files#diff-dbade1e5797a7633e024a7685a43a7cbd96ae6fefc6314294807ae34cd83712c actions.yml
instead of docker-image.yml
?
I still feel that my tests are passing here even if I have pushed a commit to deliberately fail the test.
Can you still add some more padding between the list tiles and also fix it for mobile view ?
@arteevraina , Finally I got the CI working with all the tests, can you please review it ? here's the link: https://registry-phi.vercel.app/
CI: https://github.com/fortran-lang/registry/actions/runs/4863598761/jobs/8671522602?pr=28
@arteevraina , Finally I got the CI working with all the tests, can you please review it ? here's the link: https://registry-phi.vercel.app/
CI: https://github.com/fortran-lang/registry/actions/runs/4863598761/jobs/8671522602?pr=28
As discussed in the chat, I think we will have to check for "FAILED" in order to get the correct results.
Testable link: https://registry-phi.vercel.app/
Thanks and Regards, Henil
CC @arteevraina @perazz @minhqdao